Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rocm_version.h include so that it works for ROCm 5.6 and above #44824

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 24, 2024

As suggested by @fwyzard , this change allows cmssw to build with both ROCm 5.6 and 6.X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#9153

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44824/40068

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • HeterogeneousCore/ROCmServices (heterogeneous)

@makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44824/40069

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44824 was updated. @fwyzard, @makortel, @cmsbuild can you please check and sign again.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar changed the title Revert "Update the #include files for ROCm v6.x" Update rocm_version.h include so that it works for ROCm 5.6 and above Apr 24, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-069796/39054/summary.html
COMMIT: 6f7fa6a
CMSSW: CMSSW_14_1_X_2024-04-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44824/39054/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319852
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319823
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@makortel, @fwyzard can you please review this?

@makortel
Copy link
Contributor

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

@cms-sw/orp-l2 , can you please merge this? Once this is in then I can merge cms-sw/cmsdist#9153 (ROCm revert) and trigger few NON-LTO builds

@antoniovilela
Copy link
Contributor

@cms-sw/orp-l2 , can you please merge this? Once this is in then I can merge cms-sw/cmsdist#9153 (ROCm revert) and trigger few NON-LTO builds

Ok, will merge this PR and not cms-sw/cmsdist#9153.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 097d1cb into master Apr 24, 2024
11 checks passed
@smuzaffar smuzaffar deleted the revert-44777-update_ROCm_6x_include_location branch June 14, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants